Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use Go 1.24 tool for staticcheck and goimports #1191

Merged
merged 1 commit into from
Feb 13, 2025
Merged

chore: use Go 1.24 tool for staticcheck and goimports #1191

merged 1 commit into from
Feb 13, 2025

Conversation

blgm
Copy link
Member

@blgm blgm commented Feb 13, 2025

No description provided.

ifindlay-cci
ifindlay-cci approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@ifindlay-cci ifindlay-cci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blgm blgm merged commit 141c786 into main Feb 13, 2025
8 checks passed
ifindlay-cci added a commit that referenced this pull request Feb 14, 2025
@ifindlay-cci
Revert "chore: use Go 1.24 tool for staticcheck and goimports (#1191)"
0f5d6b7 
This reverts commit 141c786.
ifindlay-cci added a commit that referenced this pull request Feb 14, 2025
@ifindlay-cci
chore: Revert go 1 24 features (#1193)
7c50eca 
* Revert "chore: use Go 1.24 tool for staticcheck and goimports (#1191)"

This reverts commit 141c786.

* Revert "chore: use Go 1.24 tool feature for Ginkgo (#1188)"

This reverts commit bc682d5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifindlay-cci ifindlay-cci ifindlay-cci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Service Management Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blgm @ifindlay-cci