-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC0031] Support for System Cloud Native Buildpacks #3898
Open
pbusko
wants to merge
15
commits into
cloudfoundry:main
Choose a base branch
from
sap-contributions:cnb-system-buildpacks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[RFC0031] Support for System Cloud Native Buildpacks #3898
pbusko
wants to merge
15
commits into
cloudfoundry:main
from
sap-contributions:cnb-system-buildpacks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbusko
changed the title
[RFC0031] CNB System Buildpacks
[RFC0031] Support for System Cloud Native Buildpacks
Jul 23, 2024
pbusko
force-pushed
the
cnb-system-buildpacks
branch
5 times, most recently
from
July 25, 2024 14:27
788251d
to
b55a772
Compare
pbusko
force-pushed
the
cnb-system-buildpacks
branch
from
September 23, 2024 06:53
b55a772
to
29d7904
Compare
pbusko
force-pushed
the
cnb-system-buildpacks
branch
from
September 30, 2024 07:30
29d7904
to
27210e1
Compare
pbusko
force-pushed
the
cnb-system-buildpacks
branch
from
October 29, 2024 08:12
27210e1
to
ca076ad
Compare
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Nicolas Bender <[email protected]>
Co-authored-by: Nicolas Bender <[email protected]>
Co-authored-by: Nicolas Bender <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Johannes Dillmann <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Pavel Busko <[email protected]>
Co-authored-by: Ralf Pannemans <[email protected]>
Co-authored-by: Nicolas Bender <[email protected]>
modulo11
force-pushed
the
cnb-system-buildpacks
branch
from
October 31, 2024 09:15
8862fab
to
c27a9a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for System (admin) Cloud Native Buildpacks
Implementation of the RFC0031
This PR requires changes to the cloud_controller_worker config, to include the
default_app_lifecycle
property with the default valuebuildpack
, similar to https://github.com/cloudfoundry/capi-release/blob/b8afc27dbfbb4dc3749485cb23ab9bf65801e26b/jobs/cloud_controller_ng/templates/cloud_controller_ng.yml.erb#L542Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
main
branchI have run all the unit tests using
bundle exec rake
I have run CF Acceptance Tests