Handle rate limited UAA #4171
Merged
Handle rate limited UAA #4171
+89
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippthun
reviewed
Jan 21, 2025
svkrieger
force-pushed
the
handle-rate-limited-uaa
branch
from
46bc06d to
b433ea0
Compare
philippthun
approved these changes
Jan 21, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jan 21, 2025
Changes in cloud_controller_ng:
- Handle rate limited UAA
PR: cloudfoundry/cloud_controller_ng#4171
Author: Sven Krieger <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
UAA might return 429 responses. This is especially relevant for the newly added UAA shadow user creation Implement shadow user creation by org manager #4113
An explanation of the use cases your change solves
This changes the error code the CC returns to the user if UAA responded with 429. Before that the user got back a 503 "CF-UaaUnavailable". Now CC returns 429 "CF-UaaRateLimited" including a random Retry-After header. (UAA does not return a Retry-After header yet).
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests