Deployment scale refactor #4212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* also start separating total instance count from current scale target
sethboyles
commented
Feb 8, 2025
| expect(up_scaler.finished_scaling?).to be false | ||
| end | ||
|
|
||
| # TODO: Currently, deployments transition to COMPLETED even if there are some instances that have not started and become routable |
There was a problem hiding this comment.
I was able to reproduce this by adding this to Dora's healthcheck endpoint:
if ENV['CF_INSTANCE_INDEX'].to_i==3
status 500
return
end
Given 6 instances and max of flight=2, the deployment will complete before the instance has started/become routable. Will fix in a future PR
sethboyles
commented
Feb 8, 2025
| @@ -1,4 +1,5 @@ | |||
| require 'prometheus/client' | |||
| require 'prometheus/client/data_stores/direct_file_store' | |||
There was a problem hiding this comment.
this was so I could use the lightweight_spec_helper for some tests
* also move logic into instance_reporters
sethboyles
force-pushed
the
deployment_scale_refactor
branch
from
41df631 to
8de2953
Compare
Samze
reviewed
Feb 12, 2025
| end | ||
|
|
||
| def desired_non_deploying_instances | ||
| [target_total_instance_count - @routable_instance_count, 0].max |
There was a problem hiding this comment.
nit Should we be consistent on direct access vs attribute reader here?
Samze
reviewed
Feb 12, 2025
|
|
||
| def scale_down_old_processes | ||
| instances_to_reduce = non_deploying_web_processes.map(&:instances).sum - desired_non_deploying_instances | ||
| return true if up_scaler.finished_scaling? |
There was a problem hiding this comment.
question Can we return true here if the downscaler is still doing its thing?
Samze
reviewed
Feb 12, 2025
| @@ -105,6 +106,17 @@ def crashed_instances_for_app(process) | |||
| raise CloudController::Errors::InstancesUnavailable.new(e) | |||
| end | |||
|
|
|||
| def instance_count_summary(process) | |||
There was a problem hiding this comment.
praise big fan of pushing this out of the updater and into the reporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests