Addressed feedback from Review

cloudfoundry · Nov 12, 2024 · f57142e · f57142e
1 parent 8f175cf
commit f57142e
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 12 deletions.
diff --git a/api/handlers/app.go b/api/handlers/app.go
@@ -223,15 +223,12 @@ func (h *App) listDroplets(r *http.Request) (*routing.Response, error) {
 	logger := logr.FromContextOrDiscard(r.Context()).WithName("handlers.app.get-droplets")
 	appGUID := routing.URLParam(r, "guid")
 
-	appListDroplets := new(payloads.AppListDroplets)
-
 	app, err := h.appRepo.GetApp(r.Context(), authInfo, appGUID)
 	if err != nil {
 		return nil, apierrors.LogAndReturn(logger, apierrors.ForbiddenAsNotFound(err), "Failed to fetch app from Kubernetes", "AppGUID", appGUID)
 	}
 
-	dropletListMessage := appListDroplets.ToMessage([]string{appGUID})
-	droplets, err := h.dropletRepo.ListDroplets(r.Context(), authInfo, dropletListMessage)
+	droplets, err := h.dropletRepo.ListDroplets(r.Context(), authInfo, repositories.ListDropletsMessage{AppGUIDs: []string{appGUID}})
 	if err != nil {
 		return nil, apierrors.LogAndReturn(logger, apierrors.ForbiddenAsNotFound(err), "Failed to fetch droplet from Kubernetes", "dropletGUID", app.DropletGUID)
 	}

diff --git a/api/payloads/app.go b/api/payloads/app.go
@@ -204,11 +204,3 @@ func (a *AppPatch) ToMessage(appGUID, spaceGUID string) repositories.PatchAppMes
 
 	return msg
 }
-
-type AppListDroplets struct{}
-
-func (a *AppListDroplets) ToMessage(appGUIDs []string) repositories.ListDropletsMessage {
-	return repositories.ListDropletsMessage{
-		AppGUIDs: appGUIDs,
-	}
-}