Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Payload validation refactoring for processes, roles, routes, and service bindings #2633

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Payload validation refactoring for processes, roles, routes, and service bindings #2633

merged 5 commits into from
Jun 27, 2023

Commits on Jun 27, 2023

  1. Use request validator in /v3/processes 

    Co-authored-by: Danail Branekov <[email protected]>
    @danail-branekov
    Kieron Browne and danail-branekov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    5339341 View commit details
    Browse the repository at this point in the history

  2. Move role api param testing to payloads package 

    We also migrated all role validation to jellydator

Issue: #1996
Co-authored-by: Danail Branekov <[email protected]>
    @danail-branekov
    Kieron Browne and danail-branekov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d4fffb5 View commit details
    Browse the repository at this point in the history

  3. Test route handler using fake request validator 

    This includes:
- switching list routes to use the requestValidator to parse URL params
- changing from go-playground to jellydator validation

Issue: #1996
    @danail-branekov
    Kieron Browne authored and danail-branekov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3bbc625 View commit details
    Browse the repository at this point in the history

  4. Move service binding payload validation to payloads 

    And migrate from go-playground to jellydator validation.
    @danail-branekov
    Kieron Browne authored and danail-branekov committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    d266e1a View commit details
    Browse the repository at this point in the history

  5. Use pointers for relationships 

    E.g. AppCreate payload has relationships.space.data.guid. If we use
pointers all the way down, we get the correct error message if the json
only contains some of the path. So providing `relationships.space` would
error with `data` being required.

Issue: #1996
Co-authored-by: Kieron Browne <[email protected]>
    @danail-branekov
    danail-branekov and Kieron Browne committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    9dec9bc View commit details
    Browse the repository at this point in the history