Fix manifest validation for random-route
#2635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validator was always raising the following error when random-route was specified:
"default-route and random-route may not be used together"
This change makes it so that it only errors when both default-route and random-route are set to true.
Related Slack discussion: https://cloudfoundry.slack.com/archives/C0297673ASK/p1687556306576749
Is there a related GitHub Issue?
No
What is this change about?
Fixes a bug where any manifest containing
random-route: true
would cause an error. Minimal example:Does this PR introduce a breaking change?
No
Acceptance Steps
Push an app with manifests containing
random-route
,default-route
, and mixtures of both. They should work in isolation and fail when both are set totrue
.Tag your pair, your PM, and/or team
@acosta11