Implement org deletion job endpoint #2638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Messed up my git author config; had to reset-author and force push to fix the CLA issue. Marked comment as resolved and set to hidden. |
akrishna90
reviewed
Jun 27, 2023
- Add check for org deletion timeout with message - Calculate status for deletion based on presence of CRD and its timestamp [#2605] Co-authored-by: Dave Walter <[email protected]>
Yeah Dave and I had the same thought about circling back if we get feedback but think it's a reasonable starting point given we already have a 1 minute timeout on app deletion. |
acosta11
changed the title
akrishna90
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2605
What is this change about?
Return status of org deletion based on underlying CFOrg resource
Does this PR introduce a breaking change?
No
Acceptance Steps
See issue.
Tag your pair, your PM, and/or team
paired w/ @davewalter