Add a fail handler printing debug info to the smoke tests #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
force-pushed
the
wip-smoke-fail-handler
branch
2 times, most recently
from
2306082
to
73fe271
Compare
Also dry up all end to end tests making them reuse more bits like - fail handlers and common funcs used in them (like printing pod logs) - env helpers Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
wip-smoke-fail-handler
branch
from
73fe271
to
3136069
Compare
danail-branekov
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2713
What is this change about?
Introduce fail handler to the smoke tests that prints more information about the app that may be slow to be deleted as well as controller logs that may help to find out if there is something weird in how we are handling finalizers
Also drying up the code around the three e2e suites: crd, smoke and e2e
Does this PR introduce a breaking change?
No
Acceptance Steps
Greent tests
Tag your pair, your PM, and/or team
@eirini