Fix build-dorifi to work with golang 1.21.0
#2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
previously approved these changes
Aug 10, 2023
georgethebeatle
previously approved these changes
Aug 10, 2023
danail-branekov
force-pushed
the
fix-build-dorifi
branch
from
348cb85
to
3d528d8
Compare
georgethebeatle
force-pushed
the
fix-build-dorifi
branch
from
3d528d8
to
b702a79
Compare
`-C` flag is now required to be the first on the command line
georgethebeatle
force-pushed
the
fix-build-dorifi
branch
from
b702a79
to
cc8ff3a
Compare
For some reason it is making controller-tests to hang and is blocking CI. We will have to investigate further and revert this commit when we find a proper fix. Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Danail Branekov <[email protected]>
georgethebeatle
force-pushed
the
fix-build-dorifi
branch
from
0d19826
to
7538d5c
Compare
georgethebeatle
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
There is a CI build failure though: https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-e2es-pr/builds/1997
What is this change about?
Fix
build-dorifito work with golang 1.21.0:-Cflag is now required to be the first on the command lineDoes this PR introduce a breaking change?
No
Acceptance Steps
Green CI