Remove code duplication in CFOrg/CFSpace controllers #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the object type `Delete` would delete the object and then a) if the object is namespace - await its `DeletionTimestamp` to get set - test env does not actually deletes namespaces b) if the object is CFOrg or CFSpace with existing underlying namespace - await their `DeletionTimestamps` to be set as they cannot be deleted while the namespace is around (due to testenv) c) otherwise - await `Get` to start returning a not found error There are few cases when synchronous deletion is not desired though, for example, a test verifying that a webhook would allow deletion. The object webhook is installed by a defaulter, but in the webhook test suite there is no object controller to eventually remove the finalizer, thus the object remains. In those cases a standard client is used. Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
force-pushed
the
issues/1184-refactor-orgspace-controllers
branch
from
c57e648
to
586203b
Compare
georgethebeatle
previously approved these changes
Sep 18, 2023
Introduce reusable namespace related (ns lifecycle, propagating secrets, rolebindings, etc.) and wire them into the controllers themselves fixes #1184 Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
force-pushed
the
issues/1184-refactor-orgspace-controllers
branch
from
586203b
to
7c83511
Compare
georgethebeatle
approved these changes
Sep 18, 2023
danail-branekov
deleted the
issues/1184-refactor-orgspace-controllers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#1184
What is this change about?
Introduce reusable namespace related (ns lifecycle, propagating
secrets, rolebindings, etc.) components and wire them into the controllers
themselves
Does this PR introduce a breaking change?
No
Acceptance Steps
No functional change