Package type validation #2875
Merged
Package type validation #2875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
previously approved these changes
Sep 18, 2023
danail-branekov
force-pushed
the
issues/2797-package-type-validation-2
branch
from
6012353
to
bc0ec92
Compare
georgethebeatle
approved these changes
Sep 18, 2023
to match the one on CF for VMs Co-authored-by: Danail Branekov <[email protected]>
* Check that the package type matches the app type when creating the package via the API * Do not error on package type and app lifecycle type mismatch when creating the CFPackage with kubectl. This is to ensure that kubectl users can create CFPackages that reference apps that do not yet exist * Do not allow changing the package type * Fail the CFBuild if CFPackage type and CFApp lifecycle type mismatch. This way kubectl users would in the end get the mismatch error. fixes #2797 Co-authored-by: Danail Branekov <[email protected]> Co-authored-by: Georgi Sabev <[email protected]> Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
force-pushed
the
issues/2797-package-type-validation-2
branch
from
bc0ec92
to
e9a8881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2797
What is this change about?
Error when package type does not match app type
package via the API
creating the CFPackage with kubectl. This is to ensure that kubectl
users can create CFPackages that reference apps that do not yet exist
This way kubectl users would in the end get the mismatch error.
Does this PR introduce a breaking change?
No
Acceptance Steps
See story
Tag your pair, your PM, and/or team
@georgethebeatle