Fix a CI flake in cfBuild controller tests #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to failed build: https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/12261#L6500636d:59 This flake has occurred a couple of times during the weekend. It was most probably caused by the cfbuild controller seeing the build success status too soon, causing it to not delegate to the delegate reconciler even once. Changing the test to wait for the first invocation of the delegate reconciler before patching the build status to successfuls state would prevent this problem. Then it would be safe to assert that the delegate call count remains stable. Also renamed the fakeStatusCondition to delegateInvokedCondition for clarity
georgethebeatle
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
This flake has occurred a couple of times during the weekend. It was
most probably caused by the cfbuild controller seeing the build success
status too soon, causing it to not delegate to the delegate reconciler
even once. Changing the test to wait for the first invocation of the
delegate reconciler before patching the build status to successfuls
state would prevent this problem. Then it would be safe to assert that
the delegate call count remains stable.
Also renamed the fakeStatusCondition to delegateInvokedCondition for
clarity
Link to failed build: https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/12261#L6500636d:59
Does this PR introduce a breaking change?
No
Acceptance Steps
Green tests
Tag your pair, your PM, and/or team
@danail-branekov