Implement POST /v3/service_plans/{guid}/visibility #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For now `public` is the only allowd value other than `admin`, which is the default - Bonus: Introduce the `visibility_type` field in the service plan resource. This makes `cf service-access` display the plan visibility correctly fixes #3275 Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
issues/3275-public-visibility
branch
from
5eccff9
to
5459664
Compare
danail-branekov
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3275
What is this change about?
Implement updating service plan visibility
publicis the only allowd value other thanadmin, which isthe default
visibility_typefield in the service planresource. This makes
cf service-accessdisplay the plan visibilitycorrectly