Include service offerings when listing plans #3419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #3279 Co-authored-by: Georgi Sabev <[email protected]>
`includes` and `fields` are quite similar concepts. The difference is that `include` inludes the complete resource, while `fields` select the fields of the resource to be included. With this commit we abstract that difference away. `IncludedResource` now has a `SelectJSONFields` method that allows picking the fields one want to see in the response. Under the hood `SelectJSONFields` uses json marshal/unmarshal, tehrefore fields selectors work on the resource json representation.
danail-branekov
force-pushed
the
issues/3279-list-plan-include-offerings
branch
from
a5e6c78
to
cea5f69
Compare
georgethebeatle
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3279
What is this change about?
Include service offerings when listing plans