Ignore space_guids param when listing service plans and allow include=space.organization
#3431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
previously approved these changes
Aug 15, 2024
georgethebeatle
force-pushed
the
wip-ignore-query-params
branch
from
d94e2d9
to
7eac2fd
Compare
It was possible to pass fileds like `fileds[service_broker.service_offering]` which make no sense as offerings have relationships to brokers, but not vice versa. Also add `spaces.organization` to the valid set of values of the `include` param. This is needed by the `cf marketplace` command. Co-authored-by: Yusmen Zabanov <[email protected]>
This is needed by the `cf service-access` command. We simply ignore the param as space scoped brokers are not supported yet. Co-authored-by: Yusmen Zabanov <[email protected]>
georgethebeatle
force-pushed
the
wip-ignore-query-params
branch
from
7eac2fd
to
6ae27b1
Compare
danail-branekov
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Ignore space_guids param when listing service plans
This is needed by the
cf service-accesscommand. We simply ignore theparam as space scoped brokers are not supported yet.
Make service_plan payload validation more strict
It was possible to pass fileds like
fileds[service_broker.service_offering]which make no sense asofferings have relationships to brokers, but not vice versa.
Also add
spaces.organizationto the valid set of values of theincludeparam. This is needed by thecf marketplacecommand.Tag your pair, your PM, and/or team
@danail-branekov