Inline the ready condition builder in the patching reconciler #3454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
force-pushed
the
ready-condition-for-all
branch
from
790847c
to
31f226d
Compare
georgethebeatle
previously approved these changes
Aug 30, 2024
georgethebeatle
force-pushed
the
ready-condition-for-all
branch
from
31f226d
to
175b875
Compare
georgethebeatle
force-pushed
the
ready-condition-for-all
branch
from
175b875
to
71e9ebe
Compare
georgethebeatle
approved these changes
Aug 30, 2024
georgethebeatle
previously approved these changes
Sep 2, 2024
* introduce `k8s.RuntimeObjectWithStatusConditions` * replace `conditions.RuntimeObjectWithStatusConditions` with `k8s.RuntimeObjectWithStatusConditions` - that made the generic signature of the awaiter a bit awkward * Make the ready condition builder availble into the patching reconciler and remove it from all the controllers * introduce the `k8s.NotReadyError` error. By returning that error in controllers, the patching reconciler sets the `Ready` condition accordingly * The kpack build reconciler no longer uses the patching reconciler as kpack build custom resource does not implement the `RuntimeObjectWithStatusConditions` interface Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
ready-condition-for-all
branch
from
2abc7bc
to
5e9681e
Compare
georgethebeatle
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2098
What is this change about?
k8s.RuntimeObjectWithStatusConditionsconditions.RuntimeObjectWithStatusConditionswithk8s.RuntimeObjectWithStatusConditions- that made the genericsignature of the awaiter a bit awkward
and remove it from all the controllers
k8s.NotReadyErrorerror. By returning that error incontrollers, the patching reconciler sets the
Readyconditionaccordingly
kpack build custom resource does not implement the
RuntimeObjectWithStatusConditionsinterfaceTag your pair, your PM, and/or team
@georgethebeatle