Fix gosec errors #3466
Merged
Fix gosec errors #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use `int32` for ports (Gateway API ports use that type) * Use `int32` for timeouts, desired instances (pod healtcheck timeout is `int32`) * Use `int64` for limits (k8s resources limits are `int64` Thus we do not have to cast ints all over the place and fix gosec issues Co-authored-by: Yusmen Zabanov <[email protected]>
danail-branekov
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
int32for ports (Gateway API ports use that type)int32for timeouts, desired instances (pod healtcheck timeout isint32)int64for limits (k8s resources limits areint64