Include service plan fields when listing service instances #3468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
previously approved these changes
Sep 9, 2024
BooleanCat
reviewed
Sep 9, 2024
tests/smoke/services_test.go
Outdated
| session := helpers.Cf("services") | ||
| Expect(session).To(Exit(0)) | ||
|
|
||
| lines, _ := it.Collect2(it.LinesString(session.Out)) |
There was a problem hiding this comment.
In go-functional v2.1.0 I've added the MustCollect consumer for cases where you know errors will not occur or where panicing is OK (such as in tests). This could be written more clearly as:
lines := it.MustCollect(it.LinesString(session.Out))
fixes #3291 Co-authored-by: Yusmen Zabanov <[email protected]>
georgethebeatle
force-pushed
the
issues/3291-service-plan-fields
branch
from
c13f55f
to
a80bf2c
Compare
danail-branekov
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3291
What is this change about?
Include service plan fields when listing service instances
Does this PR introduce a breaking change?
No
Acceptance Steps
See story