Use EnsurePatch in OSBAPI client factory tests
#3475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client factory is an utility and its tests are not executed in the context of the controllers retry loop. Therefore, in order to avoid flakes from k8s eventual consistency, we use `EnsurePatch` in tests instead of `k8sClient.Patch` to ensure that the factory sees the state of the objects the test setup creates. Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
fix-client-factory-flake
branch
from
904c0a0
to
a43106c
Compare
georgethebeatle
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
Flakes:
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/19051
https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/19049
What is this change about?
The client factory is an utility and its tests are not executed in the
context of the controllers retry loop. Therefore, in order to avoid
flakes from k8s eventual consistency, we use
EnsurePatchin testsinstead of
k8sClient.Patchto ensure that the factory sees the stateof the objects the test setup creates.
Tag your pair, your PM, and/or team
@georgethebeatle