Use make targets to install binary dependencies #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgethebeatle
previously approved these changes
Sep 16, 2024
georgethebeatle
force-pushed
the
local-bins
branch
from
fd73c16
to
13bf7b5
Compare
* Make use of file-based rules as make targets to ensure that binaries are only installed if not already available * Configure `GOBIN` env var to `./bin`. Thus `go install` installs binaries in `./bin` * Add `GOBIN` to path * Use simple binary names as `GOBIN` is on the `PATH` Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
local-bins
branch
from
13bf7b5
to
4156fbc
Compare
georgethebeatle
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
are only installed if not already available
GOBINenv var to./bin. Thusgo installinstallsbinaries in
./binGOBINto pathGOBINis on thePATHTag your pair, your PM, and/or team
@georgethebeatle