Write Succeeded condition only after adding droplet info into BuildWorkload status
#3497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @pbusko Thanks for the PR. Would you be willing to also backfill a test that verifies the fix? Looks good otherwise |
pbusko
force-pushed
the
fix-broken-state-kpack
branch
2 times, most recently
from
f6d91e5
to
d00d15e
Compare
a test has been added |
danail-branekov
approved these changes
Oct 8, 2024
danail-branekov
requested changes
Oct 8, 2024
kpack-image-builder/controllers/buildworkload_controller_test.go
Outdated
Show resolved
Hide resolved
pbusko
force-pushed
the
fix-broken-state-kpack
branch
from
aa08bba
to
4ea98eb
Compare
|
danail-branekov
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
no
What is this change about?
If an error is thrown during the generation of droplet status, the
BuildWorkloadobject ends up in a deadlock situation, where each subsequent reconciliation loop exits early and no droplet info is written.Does this PR introduce a breaking change?
no
Acceptance Steps
Tag your pair, your PM, and/or team