Issues/3293 bind async #3556
Merged
Issues/3293 bind async #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
previously approved these changes
Oct 24, 2024
gogolok
reviewed
Oct 24, 2024
| @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.16.4 | |||
| controller-gen.kubebuilder.io/version: v0.16.3 | |||
There was a problem hiding this comment.
So your local ./controllers/bin/controller-gen is not using 0.16.4?
There was a problem hiding this comment.
Nice catch, @gogolok - I totally overlooked that this is not a bump, but de-bump. Will fix that
fixes cloudfoundry#3293 Co-authored-by: Danail Branekov <[email protected]>
danail-branekov
force-pushed
the
issues/3293-bind-async
branch
from
6e20611
to
a5281bb
Compare
danail-branekov
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3293
What is this change about?
Implement asynchronous binding
Does this PR introduce a breaking change?
No