Enable purging of CFServiceInstances #3573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klapkov
commented
Oct 30, 2024
klapkov
commented
Oct 30, 2024
danail-branekov
previously requested changes
Oct 31, 2024
There was a problem hiding this comment.
Overall looks OK. I would request adding a test into the managed service instance controller to verify that whenever a CFServiceInstance without finalizers is being deleted (i.e. it has its DeletionTimestamp set), the controller does not talk to the broker.
Maybe When("the instance is purged" next to When("the instance is being deleted
georgethebeatle
force-pushed
the
purge_service_instances
branch
from
0769054
to
273919d
Compare
klapkov
force-pushed
the
purge_service_instances
branch
from
bef485a
to
322ac66
Compare
klapkov
force-pushed
the
purge_service_instances
branch
from
322ac66
to
3175373
Compare
georgethebeatle
approved these changes
Nov 8, 2024
georgethebeatle
dismissed
danail-branekov’s stale review
Requested chnges are done
georgethebeatle
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
Related to #3572
What is this change about?
Here we enable purging of Service Instances. We take advantage of the Owner Reference to Service Instances in the CFServiceBinding Object. This way, if purge is true, we just remove the finalizer on the CFServiceInstance, so the broker won't be contacted. Since the bindings are a child of the instance, they will be deleted.
I wanted to include a test case in the service_instance_repository_test for checking if a service binding is purged, but I did not work for some reason. At some point I found out that envtest has some drawbacks in this case. As per: https://book.kubebuilder.io/reference/envtest#testing-considerations - "One common example is garbage collection; because there are no controllers monitoring built-in resources, objects do not get deleted, even if an OwnerReference is set up". So we could not directly verify this via test case.