Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option --retry-all-errors when downloading go version #678

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

ivanovac
Copy link

Add option --retry-all-errors when downloading go version

  • A short explanation of the proposed change:
    Adding option --retry-all-errors to the curl command used to download the go binary

  • An explanation of the use cases your change solves
    Using just the --retry option of curl doesn't make the call stable enough as it would fail to retry in cases of 'Connection reset by peer' when there's an TCP/IP issue while trying to connect to the host, for example. Adding --retry-all-errors option to the --retry [x], would cause retry of the call, no matter what the responce error is. In this concrete case, as the called url is well known (https://buildpacks.cloudfoundry.org/dependencies/go), adding --retry-all-errors would make the call even more resilient.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have added an integration test

Add option --retry-all-errors when downloading go version
Copy link

linux-foundation-easycla bot commented Nov 29, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@radoslav-tomov
Copy link

The change is not compatible with cflinuxfs3 as the curl version there is < 1.77 . So we should merge the change once the node-buildpack stops supporting the old stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants