Only add endpoint for Routable LRP #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If LRP switches from Routable to not Routable remove the endpoint Signed-off-by: Maria Shaldybin <[email protected]> Signed-off-by: Renee Chu <[email protected]>
ameowlia
requested changes
Jun 30, 2023
ameowlia
requested changes
Jun 30, 2023
Have not tested this on windows. My expectation it should work the same. |
ameowlia
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change about?
As part of readiness health checks work route emitter should only add endpoint for routes that are Routable.
This PR accompanies executor PR Once executor emits ContainerRunning event rep will send information to BBS in StartActualLRP call, which would include information whether the container is routable.
How should this change be described in diego-release release notes?
Support readiness health checks
Please provide any contextual information.
RFC
Thank you!