Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce switch for envelope v1 metrics #456

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

b1tamara
Copy link
Contributor

Summary

  • Implement a switch to enable / disable metrics reported using Envelope V1
  • Introduce a new gorouter prometheus property "enabled" which has been automatically set to true if prometheus.port is set.
  • Do not exclude metrics reporting by prometheus and using Envelope V1.

Backward Compatibility

Breaking Change? No

@ctlong
Copy link
Member

ctlong commented Feb 20, 2025

If you want the prometheus metrics to be scraped by the Prom Scraper agent, then you'll need to configure a prom_scraper_config.yml. You can read more about that here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants