Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook Mobile and HTML add-ons have stopped working #1884

Open
tylersticka opened this issue Jun 28, 2022 · 5 comments
Open

Storybook Mobile and HTML add-ons have stopped working #1884

tylersticka opened this issue Jun 28, 2022 · 5 comments
Labels
🐛 bug Something isn't working 👷 dev 🔌 dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation 👷 environment Setup, build tools, configuration, etc.

Comments

@tylersticka
Copy link
Member

Overview

Since Renovate updated the Storybook monorepo to 6.5.9 (#1843), the following add-ons have stopped working:

Steps to reproduce

  1. Open any story in "canvas" view.
  2. Observe whether or not "Mobile" and "HTML" tabs are next to "Controls" and "Accessibility."
@tylersticka tylersticka added 🐛 bug Something isn't working 🔌 dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation 👷 environment Setup, build tools, configuration, etc. size:? 👷 dev labels Jun 28, 2022
@spaceninja spaceninja self-assigned this Jul 1, 2022
@tylersticka
Copy link
Member Author

tylersticka commented Jul 1, 2022 •
edited
Loading

@spaceninja FYI, some acceptable outcomes of this issue for me are:

  • Determine this issue is blocked by dependency updates.
  • Determine that there is a reasonable, working alternative we could use instead.
  • Suggest removing the dependency for now.

My main goal in creating this issue was to get 👀 on it to determine our best next steps. It's okay if there's no fix yet on our end.

@spaceninja spaceninja removed their assignment Jul 5, 2022
@tylersticka
Copy link
Member Author

FYI, removing this from the project backlog because it is not a launch blocker.

@spaceninja spaceninja mentioned this issue Jul 15, 2022
Closed
1 task
@tylersticka tylersticka mentioned this issue Jul 15, 2022
Merged
@spaceninja spaceninja mentioned this issue Aug 1, 2022
Closed
1 task
@spaceninja
Copy link
Member

Note that we disabled these two plugins (though they're still installed as dependencies so we can monitor updates) in #1954

@tylersticka tylersticka removed the size:? label Aug 3, 2022
@yannbf
Copy link

yannbf commented Oct 6, 2022

@spaceninja regarding Storybook Mobile, version 1.0.1 has been released which should be working now with Storybook 6.5.
It also seems to live in a different repo: https://github.com/stevensacks/storybook-mobile-addon

@spaceninja
Copy link
Member

@yannbf thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working 👷 dev 🔌 dependencies Pull requests that update a dependency file 📚 documentation Improvements or additions to documentation 👷 environment Setup, build tools, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tylersticka @spaceninja @yannbf