Add Media options, add Media Summary component, deprecate Event Summary component #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9cc9c2c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
spaceninja
approved these changes
Jul 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a more generalized Media Summary component that can fulfill the purpose of the Event Summary and other, similar linked content summaries (books, open source projects, etc.). This will allow us to avoid duplicate links in content in a consistent way.
There are a few design changes compared to Event Summary:
To facilitate a Media Summary component that directly extends the Media object,
object_classandcontent_classproperties were added to the Media object.I also installed the Storybook Status add-on to better communicate deprecated components. While I was in there, I commented out two add-ons that are no longer working (#1884) since it seemed silly to continue loading them until that's resolved.
I chose to deprecate the Event Summary rather than remove it to give us time to transition without blocking other small changes and bug fixes.
Screenshots
Testing
Review the docs page and stories for Media Summary