Set specific Node version #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
spaceninja
approved these changes
Nov 8, 2022
gerardo-rodriguez
added a commit
that referenced
this pull request
Dec 1, 2022
…terns into feature/aspect-ratio * 'main' of https://github.com/cloudfour/cloudfour.com-patterns: (30 commits) Publish Next Version (#2090) Expand centered wp-block-image captions (#2089) Update dependency stylelint-config-prettier to v9.0.4 Update dependency postcss to v8.4.19 Update dependency eslint-plugin-react to v7.31.11 (#2085) Update dependency cssnano to v5.1.14 Update dependency @types/lodash to v4.14.190 Update dependency @changesets/cli to v2.25.2 Publish Next Version (#2056) Moar social media exodus icons (#2081) Update dependency typescript to v4.9.3 (#2031) Update brand icons (#2079) Set specific Node version (#2080) Update dependency eslint to v8.25.0 Update dependency rollup-plugin-dts to v4.2.3 (#2075) Update dependency postcss to v8.4.18 (#2074) Update dependency eslint-plugin-react to v7.31.10 (#2073) Update dependency @babel/preset-env to v7.19.4 (#2072) Update dependency @changesets/cli to v2.25.0 Update dependency postcss to v8.4.17 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
A few days ago, Node v18 became the latest LTS release. But our Storybook build commands fail in Node v17 or higher.
The reason for this is that Node changed its cryptographic security requirements in version 17. This breaks the way Webpack generates hashes.
After consulting this StackOverflow thread, I had a few options to address this:
npm audit fix --force. This introduces many breaking changes.NODE_OPTIONSenvironment variable to--openssl-legacy-providereverywhere. This felt clunky to me..nvmrc.I went with the last option.
We can update to the latest LTS release once Webpack is updated to version 5 or later, which I believe depends on Storybook. Or we can switch to Vite (see #1403).
Testing
nvm ls-remotegit checkout mainnvm use && npm ci && npm startnvm use && npm ci && npm startAlternatively, you can compare the GitHub checks on this PR to that of #2079, which was stalled by this issue.