Combine + simplify nav/masthead #18
Conversation
Now uses top-down drawer similar to Solid. Does not yet address IE9 issues related to dependency on classList, but paves the way for that to be a much simpler change. Refs: #14
| box-sizing: border-box; | ||
| width: var(--Layout-nav-width); | ||
| height: 100%; | ||
| margin: 0; |
There was a problem hiding this comment.
Is this margin still needed here since it gets set above?
There was a problem hiding this comment.
Nope, good catch! I'll remove.
|
Looks good overall. Only other nitpick from me is regarding the mix of This is also something that can be deferred to another issue and addressed later. I assume there are similar opportunities for cleanup elsewhere. Thoughts? |
|
@erikjung Sorry for the delay in responding, it's just a complicated question for me to answer. I feel like I could rewrite and simplify the whole UI at this point, but the more changes I make the bigger pain it is to back-port those to this generator repository. This (mostly reductive) PR took two separate attempts and three separate instances to create (the generator, a local dev repo and a test instance of the generator output), and I spent a lot more time on it than I anticipated. If tools existed for developing, viewing and pushing updates to the UI in a single location, I honestly think I could revise the whole thing in a couple of days. It's pretty frustrating as-is, hence my lack of enthusiasm for big, sweeping changes. |
|
👍 LGTM. We can address other minor things later. |
Combine + simplify nav/masthead
Now uses top-down drawer similar to Solid, with lighter colors that are mostly inherited by default:
Does not yet address IE9 issues related to dependency on classList, but paves the way for that to be a much simpler change in a future PR.
Refs: #14
@saralohr @nicolemors