Fixing help message and improving error handling #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const-cloudinary
requested changes
Nov 7, 2023
| @@ -25,7 +24,7 @@ | |||
| @option("-A", "--auto_paginate", is_flag=True, default=False, | |||
| help="Auto-paginate Admin API calls.") | |||
| @option("-F", "--force", is_flag=True, | |||
| help="Skip initial and auto-paginate confirmation.") | |||
| help="Skip initial confirmation.") | |||
There was a problem hiding this comment.
Maybe change to Skip confirmation. or Skip user confirmation.. like, initial is kind of ambiguous, no context.
@carlevison, WDYT?
There was a problem hiding this comment.
@const-cloudinary 'Skip confirmation.' is fine.
There was a problem hiding this comment.
updated to Skip confirmation.
| @@ -63,6 +62,9 @@ def regen_derived(trans_str, eager_notification_url, | |||
| api_name="admin", | |||
| auto_paginate=auto_paginate, | |||
| force=force, return_data=True) | |||
| if trans_details is False: | |||
| exit() | |||
There was a problem hiding this comment.
Maybe write an error message saying what went wrong? Just exiting can be very confusing. And it you run it in script/cron job - you have no idea what happened/ did not happen.
There was a problem hiding this comment.
as discussed I've updated this to return False instead
|
@tommyg-cld great PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Summary of Changes
What does this PR address?
Are tests included?
Reviewer, please note:
Checklist: