Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile improvements #98

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Dockerfile improvements #98

merged 2 commits into from
Oct 16, 2024

Conversation

pataquets
Copy link
Contributor

@pataquets pataquets commented Oct 15, 2024

  • Add ENTRYPOINT, so now it's just docker run -it cloudinary [command].
  • Bump Python version to (almost) latest 3.12. Note: 3.13.0 was released just last week (as of 15-Oct).
  • Add a PYHTON_VERSION build ARG to use a specific Python base image version to build from.

Brief Summary of Changes

What does this PR address?

Are tests included?

  • Yes
  • No

Reviewer, please note:

Follow-up of #96.
Notice that current Dockerfile is not a source build, but a download-from-pypi-and-install build, and it is not pinned to any version. It'll suffice for a "Just Build ™️" from repo one liner to hit the road ASAP:

$ # Build image straight from source Github repo URL (no clone needed)
$ docker build -t cloudinary https://github.com/cloudinary/cloudinary-cli.git#main
$ # Profit!
$ docker run --rm -it cloudinary config

But it won't work for local development workflow.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I ran the full test suite before pushing the changes and all the tests pass.

@const-cloudinary const-cloudinary merged commit 58d25fb into cloudinary:master Oct 16, 2024
7 checks passed
@const-cloudinary
Copy link
Contributor

@pataquets those are great improvements!

Thank you for contribution!

@colbyfayock
Copy link

@pataquets thanks for your contribution. this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at [email protected] with your name, GitHub username, and a link to the PR where I'll send further instructions.

Happy Hacktoberfest!

@pataquets pataquets deleted the dockerfile-improvements branch October 16, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants