Xuniqueid propagate #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a947769.
| @@ -23,7 +23,7 @@ test: | |||
| $(MAKE) integration | |||
| $(MAKE) travis-cov | |||
| $(MAKE) lint | |||
| $(MAKE) check-dependencies | |||
| $(MAKE) check-dependencies || true | |||
There was a problem hiding this comment.
I would rather leave these explicitly failing so we're reminded to fix them
There was a problem hiding this comment.
It is not realistic to expect us to be always be able to update deps and if they fail then make test fails and if a build relies on that then it will fail too. That was the reasoning behind this. You still see all the red output.
added 2 commits
May 12, 2016 14:38
…unner into xuniqueid_propagate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5 for reference and previous discussion