Merge pull request #2398 from cloudnativedaysjp/fix-get-metrics-n1

GET /metrics の n+1 を解消
cloudnativedaysjp · Sep 18, 2024 · 4d2c162 · 4d2c162
2 parents c858497 + 93cbcd0
commit 4d2c162
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/app/middlewares/dreamkast_exporter.rb b/app/middlewares/dreamkast_exporter.rb
@@ -85,18 +85,20 @@ def dreamkast_chat_count(metrics)
   end
 
   def dreamkast_registrants_count(metrics)
+    profile_counts = Profile.group(:conference_id).count
     Conference.all.each do |conf|
       metrics.set(
-        conf.profiles.count,
+        profile_counts[conf.id] || 0,
         labels: { conference_id: conf.id }
       )
     end
   end
 
   def dreamkast_talks_count(metrics)
+    talk_counts = Talk.group(:conference_id).count
     Conference.all.each do |talks_count|
       metrics.set(
-        talks_count.talks.count,
+        talk_counts[talks_count.id] || 0,
         labels: { conference_id: talks_count.id }
       )
     end