Update locked ruby version to 3.3.1 #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up for #2283. BTW, given that our Ruby version is managed locally via `.ruby-version` and in production with Docker, Ruby version specification in `Gemfile` might be redundant. Should we consider removing the Ruby version specification from the Gemfile to simplify our configuration? Specifying the Ruby version in `Gemfile` was primarily useful for PaaS like Heroku.
github-actions
bot
added
the
reviewapps
onk
commented
May 8, 2024
|
|
||
| BUNDLED WITH | ||
| 2.5.3 | ||
| 2.5.9 |
There was a problem hiding this comment.
bundler v2.5.9 is the default gem version for ruby v3.3.1.
Simplecov Report
|
jacopen
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #2283.
BTW, given that our Ruby version is managed locally via
.ruby-versionand in production with Docker, Ruby version specification inGemfilemight be redundant.Should we consider removing the Ruby version specification from the Gemfile to simplify our configuration?
Specifying the Ruby version in
Gemfilewas primarily useful for PaaS like Heroku.