CNDW2024のRaketaskを追加 #2455
Merged
CNDW2024のRaketaskを追加 #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitops-for-cloudnativedays
bot
added
the
reviewapps
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
Nov 24, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
Nov 24, 2024
commit: cloudnativedaysjp/dreamkast@22c9ce6 Co-authored-by: GitHub Action <[email protected]>
gitops-for-cloudnativedays bot
pushed a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
Nov 24, 2024
gitops-for-cloudnativedays bot
added a commit
to cloudnativedaysjp/dreamkast-infra
that referenced
this pull request
Nov 24, 2024
commit: cloudnativedaysjp/dreamkast@86d0c4b Co-authored-by: GitHub Action <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 suggestion.
Comments skipped due to low confidence (1)
lib/tasks/add_talks_for_cndw2024_intermission.rake:74
- [nitpick] Use the full syntax for the
track_idvariable for clarity.
add_talk(param.merge(conference_id: conference.id, conference_day_id: day.id, track_id:, show_on_timetable: false))
| ActiveRecord::Base.logger = Logger.new($stdout) | ||
| Rails.logger.level = Logger::DEBUG | ||
|
|
||
| def add_talk(param) |
There was a problem hiding this comment.
The conference variable is used before it's defined in the add_talk function. Pass the conference variable as a parameter to the add_talk function to avoid scope issues.
Suggested change
| def add_talk(param) | |
| def add_talk(param, conference) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Simplecov Report
|
takaishi
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2日目のクロージングの時間が前倒しになったけど、1日目との整合性を取りたい＆時刻の設定はそれほど重要ではないので気にせず18時からにする