Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for native --template in Atmos for describe output #989

Closed
wants to merge 18 commits into from

Conversation

Cerebrovinny
Copy link
Collaborator

@Cerebrovinny Cerebrovinny commented Jan 30, 2025

what

why

Evidence:
CleanShot 2025-01-30 at 20 06 23

references

@mergify mergify bot added the triage Needs triage label Jan 30, 2025
@osterman
Copy link
Member

  • Snapshots were committed without test cases

@osterman
Copy link
Member

osterman commented Jan 31, 2025

Slight mistake on my part. Let’s rename the current flag to —-query or —-jq (note @aknysh already did this for describe commands and it uses yq syntax so —-query might be confusing), and make —-template use atmos templating, which is based on a combination of go template, gomplate, and Sprig. I believe we should have the functions for that to make it easy.

we are trying to mimic gh CLI:
https://cli.github.com/manual/gh_help_formatting

Copy link

mergify bot commented Jan 31, 2025

💥 This pull request now has conflicts. Could you fix it @Cerebrovinny? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Jan 31, 2025
@Cerebrovinny Cerebrovinny changed the title Add support for native --template in Atmos for list output Add support for native --template in Atmos for describe output Feb 1, 2025
@mergify mergify bot removed the conflict This PR has conflicts label Feb 1, 2025
@Cerebrovinny
Copy link
Collaborator Author

Cancelling as it needs more refinement

@mergify mergify bot removed the triage Needs triage label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants