Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose log bucket lifecycle settings #44

Merged
merged 3 commits into from
Jun 30, 2020
Merged

expose log bucket lifecycle settings #44

merged 3 commits into from
Jun 30, 2020

Conversation

deadlysyn
Copy link
Contributor

what

  • Allow module consumers to enable log bucket lifecycle
  • Enable fine-grained control of retention/tiering
  • Use defaults to maintain current behavior for those who don't opt-in

why

  • terraform-aws-s3-log-storage already created lifecycle rule, but control was not bubbled up
  • Supports work in terraform-aws-lb-s3-bucket to expose lifecycle settings
  • Lifecycle is a standard way to manage s3 assets
  • Many will have different requirements, so this provides required flexibility

references

  • Use closes #39

@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit d028054 into cloudposse:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants