Allow to use ECR replication #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrijn
requested review from
florian0410 and
RothAndrew
and removed request for
a team
|
can someone run tests?🙂 |
Gowiem
reviewed
May 25, 2023
Gowiem
reviewed
May 25, 2023
|
@dmitrijn can you please address the linting issues in your new example as well? Thanks! |
Gowiem
requested changes
May 25, 2023
|
@dmitrijn friendly ping on this -- want to wrap this up with the requested changes and we'll get it merged? |
|
@Gowiem please run tests. |
|
@dmitrijn thank you for the PR make init
make github/init
make readme |
aknysh
reviewed
Oct 16, 2023
variables.tf
Outdated
|
|
||
| variable "replication_configuration_rules" { | ||
| description = "The replication rules for a replication configuration. A maximum of 10 are allowed per" |
There was a problem hiding this comment.
please update the description
A maximum of 10 are allowed per <.....>
|
@dmitrijn this one is close, can you make the remaining change so this can be merged? |
|
This pull request is now in conflict. Could you fix it @dmitrijn? 🙏 |
|
@hans-d I took this one over, can you review? |
|
/terratest |
|
@Gowiem Can you check if all is ok for you as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #99