Make email optional (#34)

cloudposse · Feb 8, 2019 · f2e6705 · f2e6705
1 parent f4b68f3
commit f2e6705
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -175,6 +175,7 @@ Available targets:
 | datapipeline_ids | Datapipeline ids |
 | logs_bucket_name | Logs bucket name |
 | security_group_id | Security group id |
+| sns_topic_arn | Backup notification SNS topic ARN |
 
 
 

diff --git a/docs/terraform.md b/docs/terraform.md
@@ -26,4 +26,5 @@
 | datapipeline_ids | Datapipeline ids |
 | logs_bucket_name | Logs bucket name |
 | security_group_id | Security group id |
+| sns_topic_arn | Backup notification SNS topic ARN |
 
diff --git a/outputs.tf b/outputs.tf
@@ -17,3 +17,8 @@ output "security_group_id" {
   value       = "${aws_security_group.datapipeline.id}"
   description = "Security group id"
 }
+
+output "sns_topic_arn" {
+  value       = "${aws_cloudformation_stack.sns.outputs.TopicArn}"
+  description = "Backup notification SNS topic ARN"
+}
diff --git a/templates/sns.yml b/templates/sns.yml
@@ -6,13 +6,20 @@ Parameters:
   Email:
     Type: String
 
+Conditions:
+  SubscribeEmail: !Not [!Equals [ !Ref Email, ""]]
+
 Resources:
   Topic:
     Type: AWS::SNS::Topic
+
+  EmailSubscription:
+    Condition: SubscribeEmail
+    Type: AWS::SNS::Subscription
     Properties:
-      Subscription:
-        - Protocol: email
-          Endpoint: !Ref Email
+      TopicArn: !Ref Topic
+      Protocol: email
+      Endpoint: !Ref Email
 
 Outputs:
   TopicArn: