add missing global_replication_group_id variable

[amitblumshtien]

what

I added missing var global_replication_group_id so i will be able to create redis cluster and associate it to a data store.

why

missing functionality

references

(https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_global_replication_group)

[sahiljambhekar]

Are there plans to merge this in at any point? It's a really small change, but allows the module users to then use it with elasticache_global_replication_group

[amitblumshtien]

waiting for the owners to approve it.

[sahiljambhekar]

@srhopkins could you pls review?

[joe-niland]

Hi @amitblumshtien
Sorry for the delay on this.
It looks fine but we need the update the docs.

Could you please run the following and commit the result?

make init
make github/init
make readme

You may also need to install gomplate: https://docs.gomplate.ca/installing/

[sahiljambhekar]

Are there plans to merge this in at any point? It's a really small change, but allows the module users to then use it with elasticache_global_replication_group

Actually, On second thought, this change won't work, as a Replication group that's part of a global datastore, can't set it's own engine version, cluster node type etc, among other things. Most values need to be set to null. I can create an issue describing it, and contribute that fix back, unless @amitblumshtien want's to take it up.

[mergify]

💥 This pull request now has conflicts. Could you fix it @amitblumshtien? 🙏

[mergify]

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.