Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for reserved instances #148 #190

Closed
wants to merge 7 commits into from
Closed

feat: add support for reserved instances #148 #190

wants to merge 7 commits into from

Conversation

kevcube
Copy link

@kevcube kevcube commented Sep 12, 2024

No description provided.

@kevcube kevcube requested review from a team as code owners September 12, 2024 13:48
@kevcube kevcube requested review from hans-d and jamengual September 12, 2024 13:48
@mergify mergify bot added the triage Needs triage label Sep 12, 2024
@kevcube
Copy link
Author

kevcube commented Sep 12, 2024

bats is failing because not all outputs have descriptions but I am not seeing any outputs without descriptions.

@kevcube
Copy link
Author

kevcube commented Sep 12, 2024

/terratest

Gowiem
Gowiem requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevcube one best practice to follow. Also, regarding your comment:

bats is failing because not all outputs have descriptions but I am not seeing any outputs without descriptions.

See lines here in examples/complete. Fix those and request me as a reviewer and I'll give it another once through.

variables.tf Outdated Show resolved Hide resolved
@kevcube kevcube requested a review from Gowiem September 13, 2024 14:23
@Gowiem
Copy link
Member

Gowiem commented Sep 13, 2024

@kevcube see my review comment for how to fix bats tests

@kevcube
Copy link
Author

kevcube commented Sep 16, 2024

@Gowiem I see no review comment 👀

@Gowiem
Copy link
Member

Gowiem commented Sep 16, 2024

image

@kevcube

@kevcube
Copy link
Author

kevcube commented Sep 16, 2024

oh duh. ok thanks, fixed.

@kevcube
Copy link
Author

kevcube commented Sep 16, 2024

/terratest

@kevcube
Copy link
Author

kevcube commented Sep 16, 2024

/terratest

@mergify Mergify
Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @kevcube? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@mergify mergify bot closed this Oct 12, 2024
@mergify Mergify
Copy link

mergify bot commented Oct 12, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevcube @Gowiem