feat: Support label_match_statement #100
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would also be extremely useful for us to be able to allow traffic based on paths not matching regular expressions, without the ability to use not statements. |
addepar-tg
reviewed
Sep 23, 2024
| @@ -280,6 +280,85 @@ variable "geo_match_statement_rules" { | |||
| DOC | |||
| } | |||
|
|
|||
| variable "label_match_statement_rules" { | |||
There was a problem hiding this comment.
Nit: move label_match_statement_rules under ip_set_reference_statement_rules to maintain rules block alphabetical order.
|
FWIW I have tested this extensively today for our use case, and this functionality seems to work perfectly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR allows creating rules based on labels. It is specially useful if you want to block specific regions of a country.
why
We need to block certain regions that are part of Ukraine due to commercial embargoes (See examples).
references