Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a custom response body for the default block action #79

Merged
merged 6 commits into from
Jun 19, 2024
Merged

feat: add a custom response body for the default block action #79

merged 6 commits into from
Jun 19, 2024

Conversation

shashimal
Copy link
Contributor

what

Add a response body for the default blocked action by choosing from the existing custom response bodies.

why

Sometimes, users may want to display a custom response message for default blocked action.

references

@shashimal shashimal requested review from a team as code owners May 16, 2024 15:38
@mergify mergify bot added triage Needs triage needs-cloudposse Needs Cloud Posse assistance labels May 16, 2024
@mergify Mergify
Copy link

mergify bot commented May 16, 2024 •
edited by github-actions bot
Loading

These changes were released in v1.6.0.

@shashimal shashimal changed the title feat: add custom_response_body_key to default block action feat: add a custom response body for the default blcok action May 16, 2024
@shashimal shashimal changed the title feat: add a custom response body for the default blcok action feat: add a custom response body for the default block action May 16, 2024
@osterman
Copy link
Member

@shashimal sorry, somewhere we have outdated instructions telling you to run make github/init. This is introducing some old versions of our configurations.

Can you please remove any files modified in .github/*

@shashimal
Copy link
Contributor Author

@shashimal sorry, somewhere we have outdated instructions telling you to run make github/init. This is introducing some old versions of our configurations.

Can you please remove any files modified in .github/*

@osterman Removed the changes. Thanks for clarifying it.

@osterman
Copy link
Member

/terratest

@shashimal
Copy link
Contributor Author

/terratest

@osterman could you please help to run the test again.

@joe-niland joe-niland added the patch A minor, backward compatible change label May 21, 2024
@osterman
Copy link
Member

/terratest

@dudymas
Copy link

dudymas commented Jun 13, 2024

/terratest

aknysh
aknysh approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @shashimal

@mergify mergify bot removed the triage Needs triage label Jun 19, 2024
@aknysh aknysh added minor New features that do not break anything and removed patch A minor, backward compatible change needs-cloudposse Needs Cloud Posse assistance labels Jun 19, 2024
@aknysh aknysh merged commit eb8dc41 into cloudposse:main Jun 19, 2024
32 of 48 checks passed
@shashimal
Copy link
Contributor Author

thanks @shashimal

@aknysh happy to contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shashimal @osterman @dudymas @aknysh @joe-niland