feat: Expose resource stats in traces as separate event #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
disq
requested review from
ronsh12 and
erezrokah
and removed request for
ronsh12
erezrokah
approved these changes
Nov 20, 2024
disq
commented
Nov 20, 2024
| @@ -80,6 +80,13 @@ func (w *worker) resolveTable(ctx context.Context, table *schema.Table, client s | |||
| logger.Info().Msg("top level table resolver started") | |||
| } | |||
| tableMetrics := w.metrics.TableClient[table.Name][clientName] | |||
| defer func() { | |||
| span.AddEvent("sync.finish.stats", trace.WithAttributes( | |||
There was a problem hiding this comment.
Turns out you can also do span.SetAttributes(...) but having a separate "finish event" (with the stats attached, we already know when the span ended otherwise) is better.
erezrokah
approved these changes
Nov 26, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
🤖 I have created a release *beep* *boop* --- ## [4.70.0](v4.69.0...v4.70.0) (2024-11-26) ### Features * Expose resource stats in traces as separate event ([#1973](#1973)) ([e74bb27](e74bb27)) ### Bug Fixes * **deps:** Update aws-sdk-go-v2 monorepo ([#1976](#1976)) ([566409d](566409d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like:
