Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add disable_dns_servers option to subnet #87

Merged
merged 9 commits into from
Mar 12, 2024
Merged

add disable_dns_servers option to subnet #87

merged 9 commits into from
Mar 12, 2024

Conversation

disperate
Copy link
Contributor

@disperate disperate commented Mar 11, 2024 •
edited
Loading

For this change to work, we need to release a new version of the cloudscale-go-sdk containing this pull request.

For testing, switch to a local version of the go-sdk, see the readme.

@disperate disperate requested a review from alakae March 11, 2024 15:15
alakae
alakae approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@alakae alakae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have:

  • Reviewed the code
  • Pushed some tine improvements
  • Tested the new feature, including subnet import and subnet datasource.
  • Tested the upgrade path

@disperate disperate merged commit c40bb2b into master Mar 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alakae alakae alakae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@disperate @alakae