Add metrics support for poller and scaler events #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielm
changed the title
|
+1. Excited to see this merged. |
nielm
force-pushed
the
scaler-metrics
branch
5 times, most recently
from
9de9bcd
to
6fc6e0e
Compare
|
Note for anyone watching this - these counters work fine for the cloud functions deployment, but we are still debugging some issues around counter reliability in GKE deployment |
nielm
force-pushed
the
scaler-metrics
branch
3 times, most recently
from
89d9eca
to
47fa0f9
Compare
nielm
force-pushed
the
scaler-metrics
branch
5 times, most recently
from
4082c9a
to
90ac57a
Compare
nielm
force-pushed
the
scaler-metrics
branch
5 times, most recently
from
21983f9
to
25faa75
Compare
nielm
commented
Mar 11, 2024
henrybell
approved these changes
Mar 11, 2024
nielm
added
the
release-please:force-run
release-please
bot
removed
the
release-please:force-run
nielm
added a commit
that referenced
this pull request
Mar 12, 2024
* Add metrics support for scaler and poller events Including required role for metrics writing to scaler and poller service accounts. In GKE, the OpenTelemetry collector is used to collect and forward metrics to the monitoring backend. In Cloud Functions, the code is configured to send metrics to Cloud Monitoring.
This was referenced Mar 12, 2024
This was referenced Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following metrics to google-cloud-monitoring:
Scaler:
first 3 have attributes:
scaling-denied additionally has a scaling_denied_reason attribute:
Poller
first 2 have attributes: