Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ESlint and codeQL workflows, and fix errors #147

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

nielm
Copy link
Collaborator

@nielm nielm commented Nov 29, 2023

Add eslint config and npm script to root package.json
Fix all eslint errors

Add eslint github workflow
Add codeQL github workflow

@nielm nielm changed the title Add ESlint and codeQL and fix errors Add ESlint and codeQL workflows, and fix errors Nov 29, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@nielm nielm force-pushed the eslint branch 2 times, most recently from 8ff6d22 to bd6dd25 Compare November 29, 2023 18:12
@nielm nielm marked this pull request as ready for review November 29, 2023 18:12
@nielm nielm force-pushed the eslint branch 5 times, most recently from bf09d78 to d3a8386 Compare November 29, 2023 19:01
Add eslint script to root package.json
Fix all eslint errors in code

Add eslint github workflow
Add codeQL github workflow
Update dependancies
Fix CodeQL errors
Copy link
Collaborator

@davidcueva davidcueva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I found just a couple of typos.
Please make sure tests pass before merging.

src/forwarder/index.js Outdated Show resolved Hide resolved
src/scaler/scaler-core/scaling-methods/base.js Outdated Show resolved Hide resolved
@davidcueva davidcueva merged commit f679866 into cloudspannerecosystem:master Dec 1, 2023
9 checks passed
@nielm nielm deleted the eslint branch December 5, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants