Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

Deal with additional conditions properly #537

Closed
wants to merge 6 commits into from

Conversation

marcoderama
Copy link
Contributor

@marcoderama marcoderama commented Feb 18, 2021

These changes are a fix for Issue #536.

The fundamental diffs are

  • Make the Status component optional in both StatefulStores and StatefulServices. This is the natural condition when they're first created.
  • Fix up ReconcileStatefulServiceConditions()

After these changes, and testing with the setup of Issue #536, the StatefulService entity ends up with a Status section looking like:

status:
  conditions:
  - lastTransitionTime: "2021-02-18T01:15:21Z"
    message: Stateful store no-store not supported
    reason: StoreNotSupported
    status: "True"
    type: NotReady
  - lastTransitionTime: "2021-02-18T01:25:22Z"
    message: Application is in the process of updating
    reason: UpdateInProgress
    status: "True"
    type: NotReady

@marcoderama marcoderama marked this pull request as draft February 19, 2021 02:28
@marcoderama
Copy link
Contributor Author

Tests now pass but converting to draft because I want to reconsider making the Status component optional.

@marcoderama marcoderama marked this pull request as ready for review February 23, 2021 01:59
@pvlugter pvlugter closed this Mar 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants